Add drag-and-drop queue reordering, closes #34 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The easiest way to implement this is to harness GtkTreeView's reorderable property. However, this doesn't work with GtkTreeModelFilter, so the TreeView's model gets switched based on whether filtering is active. To facilitate reordering, I added playlist position as a column, so when the row data gets inserted in the new position, the TreePath (row index) and pos column can be used as move target and source, respectively. After issuing the move command, the playlist status will change and update the queue with the new positions.
|
Hi @14mRh4X0r, thanks for the PR! It seems to work at first glance, there's one major problem though: it's impossible to drag multiple items. You can select several items, but the selection gets reduced to a single item on mouse down, and that limits the functionality to dragging individual tracks around. Is there any solution to that? |
|
That's due to how GtkTreeView's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The easiest way to implement this is to harness GtkTreeView's reorderable property. However, this doesn't work with GtkTreeModelFilter, so the TreeView's model gets switched based on whether filtering is active.
To facilitate reordering, I added playlist position as a column, so when the row data gets inserted in the new position, the TreePath (row index) and pos column can be used as move target and source, respectively.
After issuing the move command, the playlist status will change and update the queue with the new positions.